[frontend] Dismiss info alert popup messages after 3 seconds (along with Unit Test) #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
requested changes
Mar 6, 2024
|
Regarding the timer earlier: Checked it during 1-1 with Johan. It was 3 seconds earlier too. We can do it whatever we feel is better. |
ananya-agarwal
changed the title
ananya-agarwal
force-pushed
the
InfoTimer
branch
from
984a47a
to
e5181cf
Compare
|
Bjorn, can you please have a look now? Are we good to merge it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The info alert popup messages will automatically go after 3 seconds from when it is shown. Since, the error and warning messages are important and we want the user to close them themselves, so such a timer is only used for the info messages.
How was this patch tested?
Attached a demo video.
The patch is manually tested on the Hue UI using a stopwatch of 3 seconds.
Demo_testing.mov
Please review Hue Contributing Guide before opening a pull request.